Skip to content

TPC: Processing of common mode values in O2#15137

Draft
tubagundem wants to merge 11 commits intoAliceO2Group:devfrom
tubagundem:TPC_CMV
Draft

TPC: Processing of common mode values in O2#15137
tubagundem wants to merge 11 commits intoAliceO2Group:devfrom
tubagundem:TPC_CMV

Conversation

@tubagundem
Copy link
Contributor

@tubagundem tubagundem commented Mar 9, 2026

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

shahor02
shahor02 reviewed Mar 9, 2026
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the class methods with lot of code be moved from the header to cxx file (including needed headers, like TFile.h and TTree.h in https://github.com/AliceO2Group/AliceO2/pull/15137/changes#diff-74cad5f291e0478b7a6334eb7e3dcdabbad615a01df0db129d836a337e76582aR26-R27 ?

@alibuild alibuild mentioned this pull request Mar 10, 2026
Closed
wiechula
wiechula requested changes Mar 11, 2026
View reviewed changes
Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tubagundem , some minor things and a couple questions:

  • How different are the CMVToVectorSpec.h and the corresponding IDC code? Could it have a common base to?
  • What is done in the TPCFactorizeCMVSpec.h? I think in the CMV we don't do factorization.

@alibuild alibuild mentioned this pull request Mar 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 left review comments

@wiechula wiechula wiechula requested changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr will be requested when the pull request is marked ready for review davidrohr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tubagundem @shahor02 @wiechula